enable CI on cloud again (server seems to be pretty hard tbh) #2376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studioj
force-pushed
the
enable-ci-again
branch
from
ee5ef87 to
fe8f216
Compare
studioj
force-pushed
the
enable-ci-again
branch
from
fe8f216 to
1ffab3c
Compare
…sleeptime in IssueTests
…name test methods for unittest compatibility
4 tasks
kohtala
reviewed
Oct 31, 2025
| with: | ||
| ref: ${{ github.event.inputs.ref }} | ||
| # Use correct ref for PRs and pushes | ||
| ref: ${{ github.head_ref || github.ref_name || github.event.inputs.ref }} |
There was a problem hiding this comment.
github.head_ref is the pull request source branch, not the code that is requested for merge. Seems to me you are checking out the wrong version. Do you really need this or the inputs.ref at all? I'd expect it goes for the correct commit without the ref. If the input is needed, it's better available from inputs context as inputs.ref, no need to go for the github.event.inputs.
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| # We only test a single version to prevent concurrent |
There was a problem hiding this comment.
You can add concurrency to prevent this workflow from running concurrently.
concurrency:
group: jira-cloud-tests
cancel-in-progress: false
| push: | ||
| branches: | ||
| - main | ||
| - "*" |
There was a problem hiding this comment.
Isn't this the same as not specifying branches at all? Or do you plan to change it for main only?
on:
push:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.